Re: [RFC PATCH 0/3] mmc: sdhci: sdhci-msm: Add more debug logs

From: Jeremy McNicoll
Date: Mon Jan 16 2017 - 20:09:53 EST


On Fri, Dec 30, 2016 at 05:02:08PM +0530, Ritesh Harjani wrote:
> Below is a small set of patches which provide useful info for
> debugging issues.
>
> Patch 1 :- This provide callback mechanism for platform drivers
> to dump their necessary register info at the time of sdhci_dumpregs.
>
> Patch 2 :- This implements this callback (->platform_dumpregs)
> for sdhci-msm.
>
> Patch 3 :- Adds more logs for data errors to aid debugging.
>
> Ritesh Harjani (1):
> mmc: sdhci: Add more debug info in case of data error
>
> Sahitya Tummala (2):
> mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops.
> mmc: sdhci-msm: Implement platform_dumpregs callback in sdhci-msm
>
> drivers/mmc/host/sdhci-msm.c | 34 ++++++++++++++++++++++++++++++++++
> drivers/mmc/host/sdhci.c | 24 ++++++++++++++++++++++--
> drivers/mmc/host/sdhci.h | 1 +
> 3 files changed, 57 insertions(+), 2 deletions(-)
>

This series was part of my SDHCI enablement on my Nexus 5X and
everything still seems to work ok.

Tested-by: Jeremy McNicoll <jeremymc@xxxxxxxxxx>


> --
> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project.
>