Re: [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

[Steve Longerbeam]

On 01/16/2017 04:55 AM, Philipp Zabel wrote:
> On Fri, 2017-01-13 at 15:04 -0800, Steve Longerbeam wrote:
>
> > > > @@ -299,6 +326,52 @@
> > > >    	pinctrl-names = "default";
> > > >    	pinctrl-0 = <&pinctrl_i2c2>;
> > > >    	status = "okay";
> > > > +
> > > > +	ov5640: camera@40 {
> > > > +		compatible = "ovti,ov5640";
> > > > +		pinctrl-names = "default";
> > > > +		pinctrl-0 = <&pinctrl_ov5640>;
> > > > +		clocks = <&mipi_xclk>;
> > > > +		clock-names = "xclk";
> > > > +		reg = <0x40>;
> > > > +		xclk = <22000000>;
> > > This is superfluous, you can use clk_get_rate on mipi_xclk.
> > This property is actually there to tell the driver what to set the
> > rate to, with clk_set_rate(). So you are saying it would be better
> > to set the rate in the device tree and the driver should only
> > retrieve the rate?
> Yes. Given that this is a reference clock input that is constant on a
> given board and never changes during runtime, I think this is the
> correct way. The clock will be fixed rate on most boards, I assume.

Ok, that makes sense, I'll make that change.

Steve