Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check

[Michal Hocko]

[Let's add Andrew]

On Mon 16-01-17 10:16:43, Borislav Petkov wrote:
> From: Borislav Petkov <bp@xxxxxxx>
> 
> We wanna know who's doing such a thing. Like slab.c does that.

Yes this was an omission on my side in 72baeef0c271 ("slab: do not panic
on invalid gfp_mask").
> 
> Signed-off-by: Borislav Petkov <bp@xxxxxxx>

Acked-by: Michal Hocko <mhocko@xxxxxxxx>

Thanks!

> ---
>  mm/slub.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 067598a00849..1b0fa7625d6d 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1623,6 +1623,7 @@ static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
>  		flags &= ~GFP_SLAB_BUG_MASK;
>  		pr_warn("Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n",
>  				invalid_mask, &invalid_mask, flags, &flags);
> +		dump_stack();
>  	}
>  
>  	return allocate_slab(s,
> -- 
> 2.11.0

-- 
Michal Hocko
SUSE Labs