Re: next: s390 allyesconfig fails to compile samples/seccomp

From: Kees Cook
Date: Fri Jan 06 2017 - 15:18:55 EST


On Fri, Jan 6, 2017 at 7:04 AM, Michal Hocko <mhocko@xxxxxxxxxx> wrote:
> Hi,
> I am not relly sure what went wrong, but I've noticed that allyesconfig
> doesn't compile with my s390 crosscompiler with a strange error
> messages for linux-next (next-20170106). Linus' tree compiles just fine.
> It smells like some headers include problems because
> $ git diff origin/master..next/master -- samples/seccomp/
> doesn't show anything...

Oh, how strange. Did __BITS_PER_LONG move around? That's part of uapi...


>
> samples/seccomp/bpf-helper.h:134:2: error: #error __BITS_PER_LONG value unusable.
> #error __BITS_PER_LONG value unusable.
> ^

#include <asm/bitsperlong.h> /* for __BITS_PER_LONG */

Hm, maybe this should be uapi/asm/bitsperlong.h ?

Let me see if I can reproduce this...

-Kees

--
Kees Cook
Nexus Security