Re: [PATCH v6 3/3] serial: 8250_pci: remove exar code

[Andy Shevchenko]

On Thu, Jan 5, 2017 at 4:35 PM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Thu, Jan 5, 2017 at 12:20 PM, Sudip Mukherjee
> <sudipm.mukherjee@xxxxxxxxx> wrote:
>> Remove the exar specific codes from 8250_pci and blacklist those chips
>> so that the exar serial binds to the devices.
>
> exar -> Exar ?
>
>> +#define PCI_DEVICE_ID_COMMTECH_4222PCI335 0x0004
>> +#define PCI_DEVICE_ID_COMMTECH_4224PCI335 0x0002
>> +#define PCI_DEVICE_ID_COMMTECH_2324PCI335 0x000a
>> +#define PCI_DEVICE_ID_COMMTECH_2328PCI335 0x000b
>
> This is not related to the patch. Create a separate one.
>
>> @@ -3734,6 +3538,8 @@ enum pci_board_num_t {
>>         { PCI_VDEVICE(INTEL, 0x228c), },
>>         { PCI_VDEVICE(INTEL, 0x9ce3), },
>>         { PCI_VDEVICE(INTEL, 0x9ce4), },
>
> + empty line
>
>> +       /* Exar devices */
>> +       { PCI_VDEVICE(EXAR, PCI_ANY_ID), },
>>  };

Ah, one more. Set default for your new driver to be SERIAL_8250.
Otherwise users will lost it, right?

-- 
With Best Regards,
Andy Shevchenko