Re: [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

From: Jean Delvare
Date: Wed Jan 04 2017 - 05:18:32 EST


On Tue, 3 Jan 2017 10:06:41 +0100, Benjamin Tissoires wrote:
> On Dec 29 2016 or thereabouts, Pali RohÃr wrote:
> > So 4d5538f5882a is breaking lis3lv02d driver...
>
> Apologies for that.
>
> I could easily fix this by adding a kernel API to know whether the
> provided irq is from Host Notify or if it was coming from an actual
> declaration. However, I have no idea how many other drivers would
> require this (hopefully only this one).
>
> One other solution would be to reserve the Host Notify IRQ and let the
> actual drivers that need it to set it, but this was not the best
> solution according to Dmitri. On my side, I am not entirely against this
> given that it's a chip feature, so the driver should be able to know
> that it's available.
>
> Dmitri, Wolfram, Jean, any preferences?

I did not look at your work so I do not feel qualified to give advice
on the proper way. I trust you to make the right decision :-)

--
Jean Delvare
SUSE L3 Support