Re: [PATCH] btrfs: file.c: file cleanup

From: David Sterba
Date: Tue Jan 03 2017 - 11:07:12 EST


On Fri, Dec 16, 2016 at 03:17:33PM +0100, Philippe Loctaux wrote:
> cleaned up the file with checkpatch
^^^^^^^^^^^^^^^

Sorry, this is an example of what should not be done. Checkpatch can
detect lots of things that once were valid or tolerated but are not
today. There are minor coding style violations that have accumulated
over the years, missing newline here and there or the extra { } around
statements. We can live with that and change it eventually when
modifying the surrounding code. I'm happy to apply cleanup patches that
are a byproduct of actually reading the code, but just running
checkpatch and generating patches is below the treshold.