Re: [PATCH 1/2] HID: intel-ish-hid: add printf attribute to print_log()

From: Jiri Kosina
Date: Mon Jan 02 2017 - 07:17:19 EST


On Thu, 22 Dec 2016, Nicolas Iooss wrote:

> Structure ishtp_device contains a logging function, print_log(), which
> formats some of its parameters using vsnprintf(). Add a __printf
> attribute to this function field (and to ish_event_tracer()) in order to
> detect at compile time issues related to the printf-like formatting.
>
> While at it, make format parameter a const pointer as print_log() is not
> supposed to modify it.

Both patches applied to for-4.11/intel-ish. Thanks,

--
Jiri Kosina
SUSE Labs