Re: [PATCH v4 1/2] net: 3com: typhoon: typhoon_init_one: fix incorrect return values
From: David Miller
Date: Fri Dec 30 2016 - 15:27:24 EST
From: Thomas Preisner <thomas.preisner+linux@xxxxxx>
Date: Fri, 30 Dec 2016 03:37:53 +0100
> In a few cases the err-variable is not set to a negative error code if a
> function call in typhoon_init_one() fails and thus 0 is returned
> instead.
> It may be better to set err to the appropriate negative error
> code before returning.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188841
>
> Reported-by: Pan Bian <bianpan2016@xxxxxxx>
> Signed-off-by: Thomas Preisner <thomas.preisner+linux@xxxxxx>
> Signed-off-by: Milan Stephan <milan.stephan+linux@xxxxxx>
Applied to net-next.