Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f

[John Crispin]

On 21/12/2016 11:27, Cyrille Pitchen wrote:
> Hi all,
> 
> Le 21/12/2016 Ã 08:23, John Crispin a Ãcrit :
>> From: Andrà Valentin <avalentin@xxxxxxxxxxx>
>>
>> This patch adds support for a new macronix spi flash chip. We have had this
>> patch inside our tree for a while and people are actively using routers
>> with this chip.
>>
>> Signed-off-by: John Crispin <john@xxxxxxxxxxx>
>> Signed-off-by: Andrà Valentin <avalentin@xxxxxxxxxxx>
>> ---
>> Changes in V2
>> * add description
>> * add SECT_4K
>> * fix indenting
>>
>>  drivers/mtd/spi-nor/spi-nor.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index 171adb3..bfff159 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -868,6 +868,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
>>  	{ "mx25l3205d",  INFO(0xc22016, 0, 64 * 1024,  64, SECT_4K) },
>>  	{ "mx25l3255e",  INFO(0xc29e16, 0, 64 * 1024,  64, SECT_4K) },
>>  	{ "mx25l6405d",  INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
>> +	{ "mx25u3235f",	 INFO(0xc22536, 0, 64 * 1024,  64, SECT_4K) },
> 
> According to its datasheet, the Macronix MX25U3235F also supports Fast Read
> 1-1-2 (3Bh) and Fast Read 1-1-4 (EBh) hence the SPI_NOR_DUAL_READ
> and SPI_NOR_QUAD_READ flags should be set as well.
> 
> Best regards,
> 
> Cyrille

Hi Cyrille,

thanks for the help, I'll update the patches and get the original
submitters to test them before resending the series

	John

> 
>>  	{ "mx25u6435f",  INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
>>  	{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
>>  	{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
>>
>