Re: [net-next][PATCH v2 10/18] RDS: IB: track and log active side endpoint in connection

From: David Miller
Date: Wed Dec 07 2016 - 10:53:55 EST


From: Santosh Shilimkar <santosh.shilimkar@xxxxxxxxxx>
Date: Tue, 6 Dec 2016 20:01:48 -0800

> @@ -181,6 +181,9 @@ struct rds_ib_connection {
>
> /* Batched completions */
> unsigned int i_unsignaled_wrs;
> +
> + /* Endpoint role in connection */
> + int i_active_side;
> };
>
...
> @@ -685,6 +686,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id)
> if (ic->i_cm_id == cm_id)
> ret = 0;
> }
> + ic->i_active_side = true;
> return ret;
> }
>
> @@ -859,6 +861,7 @@ void rds_ib_conn_path_shutdown(struct rds_conn_path *cp)
> ic->i_sends = NULL;
> vfree(ic->i_recvs);
> ic->i_recvs = NULL;
> + ic->i_active_side = false;
> }
>
> int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp)

Use type "bool", not "int", for true/false values.