Re: [PATCH 1/1] net: wireless: intersil: fix improper return value

From: Kalle Valo
Date: Wed Dec 07 2016 - 07:00:41 EST


Pan Bian <bianpan2016@xxxxxxx> writes:

> Function orinoco_ioctl_commit() returns 0 (indicates success) when the
> call to orinoco_lock() fails. Thus, the return value is inconsistent with
> the execution status. It may be better to return "-EBUSY" when the call
> to orinoco_lock() fails.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188671
>
> Signed-off-by: Pan Bian <bianpan2016@xxxxxxx>
> ---
> drivers/net/wireless/intersil/orinoco/wext.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Please use prefix "orinoco:", more info:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name

--
Kalle Valo