Re: [PATCH] uapi glibc compat: fix outer guard of net device flags enum

From: David Miller
Date: Tue Dec 06 2016 - 10:45:29 EST


From: Mikko Rapeli <mikko.rapeli@xxxxxx>
Date: Mon, 5 Dec 2016 19:34:02 +0200

> On Sat, Dec 03, 2016 at 05:31:45PM +0100, Jonas Gorski wrote:
>> Fix a wrong condition preventing the higher net device flags
>> IFF_LOWER_UP etc to be defined if net/if.h is included before
>> linux/if.h.
>>
>> The comment makes it clear the intention was to allow partial
>> definition with either parts.
>>
>> This fixes compilation of userspace programs trying to use
>> IFF_LOWER_UP, IFF_DORMANT or IFF_ECHO.
>>
>> Fixes: 4a91cb61bb99 ("uapi glibc compat: fix compile errors when glibc net/if.h included before linux/if.h")
>> Signed-off-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>
>
> Reviewed-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
>
> Yep, sorry about the logic error. Thanks for the fix!

Applied.

Jonas, please properly put netdev@xxxxxxxxxxxxxxx on the CC: for networking
patches in the future.

Thank you.