Re: [PATCH 5/7] perf tools: Force fixdep compilation at the start of the build

From: Jiri Olsa
Date: Tue Dec 06 2016 - 05:48:13 EST


On Mon, Dec 05, 2016 at 05:02:51PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Dec 04, 2016 at 09:42:56PM +0100, Jiri Olsa escreveu:
> > The fixdep tool needs to be built before everything else,
> > because it fixes every object dependency file.
> >
> > We handle this currently by making all objects to depend
> > on fixdep, which is error prone and is easily forgotten
> > when new object is added.
> >
> > Instead of this, this patch force fixdep tool to be built
> > as the first target in the separate make session. This way
> > we don't need to handle extra fixdep dependencies and we are
> > certain there's no fixdep race with any parallel make job.
>
> With your updated version I'm getting this:
>
> $ make -k O=/tmp/build/perf -C tools/perf install-bin
> <BIG SNIP>
> LINK /tmp/build/perf/libperf-gtk.so
> INSTALL GTK UI
> install: cannot change permissions of â/lib64â: Operation not permitted
> install: cannot create regular file '/lib64/libperf-gtk.so': Permission denied
> Makefile.perf:738: recipe for target 'install-gtk' failed
> make[2]: *** [install-gtk] Error 1
> make[2]: *** Waiting for unfinished jobs....
> Makefile.perf:383: recipe for target 'sub-make' failed
> make[1]: *** [sub-make] Error 2
> Makefile:108: recipe for target 'install-bin' failed
> make: *** [install-bin] Error 2
> make: Leaving directory '/home/acme/git/linux/tools/perf'

hum, tests/make does not cover $HOME installation :-\

anyway, I needed to do more changes and I pushed them all
into my perf/fixes again and now I'm running all tests..

it also has the check-headers.sh fix we discussed

I'll post later today if the tests are ok

thanks,
jirka