Re: [PATCH 14/22] staging: lustre: obd: add callback for llog_cat_process_or_fork

From: Greg Kroah-Hartman
Date: Tue Dec 06 2016 - 05:08:16 EST


On Fri, Dec 02, 2016 at 07:53:21PM -0500, James Simmons wrote:
> From: Alexander Boyko <alexander.boyko@xxxxxxxxxxx>
>
> Currently llog_process_or_fork() is hard coded to
> always pass the function pointer llog_cat_process_cb().
> Change llog_cat_process_or_fork() to pass in any
> function pointer which will allow us more options
> for llog_cat callback routines in the future.

Don't change this until you have an actual user for this. Adding
infrastructure that is not used is not ok for a staging driver, or
really any kernel driver at all.

sorry,

greg k-h