Re: [v3 PATCH] netlink: Do not schedule work from sk_destruct

From: David Miller
Date: Mon Dec 05 2016 - 19:44:24 EST


From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 5 Dec 2016 15:28:21 +0800

> It is wrong to schedule a work from sk_destruct using the socket
> as the memory reserve because the socket will be freed immediately
> after the return from sk_destruct.
>
> Instead we should do the deferral prior to sk_free.
>
> This patch does just that.
>
> Fixes: 707693c8a498 ("netlink: Call cb->done from a worker thread")
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Applied, thanks Herbert.