Re: [PATCH] block: fix unintended fallthrough in generic_make_request_checks()

From: Nicolai Stange
Date: Mon Dec 05 2016 - 19:05:59 EST


Nicolai Stange <nicstange@xxxxxxxxx> writes:

> ---
> Applicable to next-20161202.
>
> Note that after this patch, I'm seeing a single
> EXT4-fs (dm-1): Delayed block allocation failed for inode 2625094 at
> logical offset 2032 with max blocks 2 with error 121
> with 121 == EREMOTEIO
>
> This is because my SATA sda reports 0x20 (invalid command) back
> in response to 0x41 (WRITE_SAME).
>
> After this has happened, sd_done() disables "write same" once and for
> all, hence only this single message.
>
> I expect this to get fixed by
> https://patchwork.kernel.org/patch/9321963/

Just FYI: Not really, the (supposedly) corresponding commit has already
been in linux-next when I was testing: commit 0ce1b18c42a5 ("libata:
Some drives failing on SCT Write Same").

I sent separate patch for this issue:
http://lkml.kernel.org/r/20161205235638.11539-1-nicstange@xxxxxxxxx

Regards,

Nicolai