Re: [PATCH v2 2/2] dell-wmi: Add events created by Dell Rugged 2-in-1s

[Andy Shevchenko]

On Sat, Nov 19, 2016 at 6:33 PM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Thu, Jul 28, 2016 at 8:53 PM, Mario Limonciello
> <mario_limonciello@xxxxxxxx> wrote:
>> The Dell Rugged 7202 has 3 programmable buttons (labeled P1, P2, P3)
>> and a detachable keyboard/mouse dock.
>>
>> Signed-off-by: Mario Limonciello <mario_limonciello@xxxxxxxx>
>
> There was a long discussion in the past. Just to get it clear. Are we
> all okay with version 2 of this series?

Darren, FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

>
>> ---
>>  drivers/platform/x86/dell-wmi.c | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
>> index 866bf73..28ec17a 100644
>> --- a/drivers/platform/x86/dell-wmi.c
>> +++ b/drivers/platform/x86/dell-wmi.c
>> @@ -274,6 +274,16 @@ static const struct key_entry dell_wmi_keymap_type_0010[] __initconst = {
>>
>>         /* Stealth mode toggle */
>>         { KE_IGNORE, 0x155, { KEY_RESERVED } },
>> +
>> +       /* Rugged magnetic dock attach/detach events */
>> +       { KE_IGNORE, 0x156, { KEY_RESERVED } },
>> +       { KE_IGNORE, 0x157, { KEY_RESERVED } },
>> +
>> +       /* Rugged programmable (P1/P2/P3 keys) */
>> +       { KE_KEY,    0x850, { KEY_PROG1 } },
>> +       { KE_KEY,    0x851, { KEY_PROG2 } },
>> +       { KE_KEY,    0x852, { KEY_PROG3 } },
>> +
>>  };

-- 
With Best Regards,
Andy Shevchenko