Re: [PATCH v2 2/6] dax: remove leading space from labels

From: Jan Kara
Date: Thu Dec 01 2016 - 11:33:50 EST


On Thu 01-12-16 08:26:19, Ross Zwisler wrote:
> On Thu, Dec 01, 2016 at 09:11:44AM +0100, Jan Kara wrote:
> > On Wed 30-11-16 16:45:29, Ross Zwisler wrote:
> > > No functional change.
> > >
> > > As of this commit:
> > >
> > > commit 218dd85887da (".gitattributes: set git diff driver for C source code
> > > files")
> > >
> > > git-diff and git-format-patch both generate diffs whose hunks are correctly
> > > prefixed by function names instead of labels, even if those labels aren't
> > > indented with spaces.
> > >
> > > Signed-off-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
> >
> > Didn't we agree do leave this for a bit later?
>
> Sorry, I thought you just asked to not have to edit your "Page invalidation
> fixes" series because of this change. This series is based on a tree that
> already includes your page invalidation work, so it shouldn't cause you any
> thrash.

Ah, I see, I didn't notice. Then it's fine :). Thanks.

Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR