Re: [PATCH 37/39] mtd: nand: denali: support "nand-ecc-strength" DT property

From: Rob Herring
Date: Thu Dec 01 2016 - 11:16:04 EST


On Sun, Nov 27, 2016 at 03:06:23AM +0900, Masahiro Yamada wrote:
> Historically, this driver tried to choose as big ECC strength as
> possible, but it would be reasonable to allow DT to set a particular
> ECC strength with "nand-ecc-strength" property.
>
> Going forward, DT platforms should specify "nand-ecc-strength" or
> "nand-ecc-maximize" to show the ECC strength strategy explicitly.
>
> If nothing is specified in DT, "nand-ecc-maximize" is implied since
> this was the original behavior. It applies to PCI platforms too.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
>
> .../devicetree/bindings/mtd/denali-nand.txt | 5 ++++

I'd prefer all the DT changes be in 1 patch, but

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> drivers/mtd/nand/denali.c | 27 +++++++++++++++++++++-
> drivers/mtd/nand/denali_pci.c | 2 ++
> 3 files changed, 33 insertions(+), 1 deletion(-)