Re: [PATCH v2 1/6] tracing: add __print_flags_u64()

From: Ross Zwisler
Date: Thu Dec 01 2016 - 10:35:08 EST


On Thu, Dec 01, 2016 at 09:12:54AM -0500, Steven Rostedt wrote:
> On Wed, 30 Nov 2016 16:45:28 -0700
> Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> wrote:
> > diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
> > index 3fc2042..ed4398f 100644
> > --- a/kernel/trace/trace_output.c
> > +++ b/kernel/trace/trace_output.c
> > @@ -124,6 +124,44 @@ EXPORT_SYMBOL(trace_print_symbols_seq);
> >
> > #if BITS_PER_LONG == 32
> > const char *
> > +trace_print_flags_seq_u64(struct trace_seq *p, const char *delim,
> > + unsigned long long flags,
> > + const struct trace_print_flags_u64 *flag_array)
> > +{
> > + unsigned long mask;
>
> Don't you want mask to be unsigned long long?

Yep, thanks for spotting that. I'll fix it in v3.