Re: Odd build breakage in 4.9-rc7

From: Prarit Bhargava
Date: Thu Dec 01 2016 - 07:47:56 EST




On 11/30/2016 05:41 PM, Nicolas Pitre wrote:
> On Wed, 30 Nov 2016, Linus Torvalds wrote:
>
>> On Wed, Nov 30, 2016 at 10:50 AM, Prarit Bhargava <prarit@xxxxxxxxxx> wrote:
>>>
>>> It comes back. The steps to reproduce this are:
>>>
>>> 1. checkout latest linux.git
>>> 2. make -j112
>>>
>>> (IOW, it occurs 100% of the time for me on a clean tree.)
>
> I don't have access to such hardware where -j112 could ever make sense. :-)

:) I could push the builds onto the -j256 but I'm doing other stuff over there. :)

> In other words, I can't reproduce regardless of the -j value I try.
>
>> I suspect it's not new, it's just that you are able to hit the timing
>> just right (and the new include presumable makes that just be much
>> easier).
>
> Here's the best fix I can think of. I can't convince myself any other
> location would be 100% safe. Obviously I can't confirm if this actually
> fixes anything.
>
> ----- >8
> Subject: kbuild: make sure autoksyms.h exists early
>

I'm building with this patch on top of latest now. I will put it in a tight
loop and clear the drop_caches between builds to see if I can make it fail.

Thanks Nicolas -- your help is very much appreciated.

P.