Re: [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c

From: Jason Gunthorpe
Date: Wed Nov 23 2016 - 15:02:12 EST


On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote:
> The device driver code for the event log has the init functions and
> TPM 1.2 parsing logic both defined in same file(tpm_eventlog.c).
>
> Since the initialization functions are common with the TPM 2.0 event
> log support, this patch splits tpm_eventlog.c to have only TPM 1.2
> event log parsing logic and moves the init functions into
> tpm_eventlog_init.c.

I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this
_init thing..

Jason