Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

From: Matthias Brugger
Date: Wed Nov 23 2016 - 13:33:07 EST


Hi Hongzhou,

On 12/05/16 04:55, Hongzhou Yang wrote:
On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote:
On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote:
Hi,

On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote:
On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote:
On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun
<chunfeng.yun@xxxxxxxxxxxx> wrote:

the default mode of GPIO16 pin is gpio, when set EINT16 to
IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be
fixed when set its default mode as usb iddig.

Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>


Chunfeng, GPIO16 can be used as EINT16 mode, but the pinmux should be 0.
If you want to set its default mode to iddig, you should set it in dts.

I set it in DTS, but it didn't work, because when usb driver requested
IRQ, pinmux was switched back to default mode set by
MTK_EINT_FUNCTION().


After confirmed, there are something wrong with data sheet and pinmux
table, and GPIO16 can only receive interrupt by mode 1. So

Acked-by: Hongzhou Yang <hongzhou.yang@xxxxxxxxxxxx>


Linus,

We find there are some other pins still have the same problem, so please
hold on it. Sorry for so much noise.


Did you made any progress on this? I didn't see any patch on the mailing list.

Regards,
Matthias