Re: [PATCH] Lock down drivers that can have io ports, io mem, irqs and dma changed

From: David Howells
Date: Wed Nov 23 2016 - 07:59:04 EST


Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> wrote:

> You might also need to disable CIS overrides and CIS firmware loading for
> PCMCIA drivers, I presume. That needs two changes:
>
> - Abort in drivers/pcmcia/ds.c::pcmcia_load_firmware() or disable
> the CONFIG_PCMCIA_LOAD_CIS config option permanently.

This really ought to be handled through signature checking in
request_firmware().

> - Abort in drivers/pcmcia/cistpl.c::pccard_store_cis() or remove
> write access to the "cis" file in
> drivers/pcmcia/cistpl.c::pccard_cis_attr

What is that doing? Allowing the device to be reconfigured?

David