Re: [PATCH 1/2] of: base: add support to get machine model name

[Sudeep Holla]

On 22/11/16 21:35, Rob Herring wrote:
> On Tue, Nov 22, 2016 at 12:44 PM, Frank Rowand <frowand.list@xxxxxxxxx> wrote:

[...]

> > This patch adds a function that leads to conflating the "model" property
> > and the "compatible" property. This leads to opaque, confusing and unclear
> > code where ever it is used.   I think it is not good for the device tree
> > framework to contribute to writing unclear code.
> >
> > Further, only two of the proposed users of this new function appear to
> > be proper usage.  I do not think that the small amount of reduced lines
> > of code is a good trade off for the reduced code clarity and for the
> > potential for future mis-use of this function.
> >
> > Can I convince you to revert this patch?
>
> Yes, I will revert.
>
> > If not, will you accept a patch to change the function name to more
> > clearly indicate what it does?  (One possible name would be
> > of_model_or_1st_compatible().)
>
> I took it as there's already the FDT equivalent function.

Yes it was mainly for non of_flat_* replacement for
of_flat_dt_get_machine_name

--
Regards,
Sudeep