Re: [patch 1/5] powercap/intel_rapl: Add missing domain data update on hotplug

From: Jacob Pan
Date: Tue Nov 22 2016 - 20:20:22 EST


On Tue, 22 Nov 2016 21:15:58 -0000
Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> The more interesting question is why rapl_update_domain_data() exists
> at all as nothing ever uses that data.

You are right, initial domain data are read at initialization time but
not used. I seem to remember I did this trying to save and restore rapl
raw settings between module load and unload. But I forgot to use it
for restore :(.

Thanks,

Jacob