Re: [PATCH] spi: spi-ti-qspi: reinit of completion variable

From: Mark Brown
Date: Tue Nov 22 2016 - 07:27:54 EST


On Tue, Nov 22, 2016 at 12:54:06PM +0530, prahlad venkata wrote:
> Did anybody got chance to review this patch?
> I feel this is a trivial yet required fix.

Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, though there are some other maintainers who like them - if in
doubt look at how patches for the subsystem are normally handled.

Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

Attachment: signature.asc
Description: PGP signature