Re: [PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation

From: Linus Walleij
Date: Tue Nov 22 2016 - 03:47:27 EST


On Wed, Nov 16, 2016 at 4:20 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:

> This function clearly never worked and always returns true,
> as pointed out by gcc-7:
>
> arch/arm/mach-ux500/pm.c: In function 'prcmu_is_cpu_in_wfi':
> arch/arm/mach-ux500/pm.c:137:212: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context]
>
> With the added braces, the condition actually makes sense.
>
> Fixes: 34fe6f107eab ("mfd : Check if the other db8500 core is in WFI")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Will you apply it directly to ARM SoC or should I queue it and
send it with a pull request?

Yours,
Linus Walleij