Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

[Zhang Rui]

On Tue, 2016-11-22 at 09:51 +0800, Caesar Wang wrote:
> å 2016å11æ19æ 11:31, Caesar Wang åé:
> > 
> > Brian,
> > 
> > å 2016å11æ19æ 07:52, Brian Norris åé:
> > > 
> > > These error messages don't give much information about what went
> > > wrong.
> > > It would be nice, for one, to see what invalid temperature was
> > > being
> > > requested when conversion fails. It's also good to return an
> > > error when
> > > we can't handle a conversion properly.
> > > 
> > > While we're at it, fix the grammar too.
> > > 
> > > Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> > > ---
> > > Note: it'd probably be even nicer to know which sensor this was,
> > > butÂ
> > > we've
> > > kinda abstracted that one away by this point...
> > > 
> > > Â drivers/thermal/rockchip_thermal.c | 7 +++++--
> > > Â 1 file changed, 5 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/thermal/rockchip_thermal.cÂ
> > > b/drivers/thermal/rockchip_thermal.c
> > > index e227a9f0acf7..35554d146b9d 100644
> > > --- a/drivers/thermal/rockchip_thermal.c
> > > +++ b/drivers/thermal/rockchip_thermal.c
> > > @@ -424,7 +424,8 @@ static u32 rk_tsadcv2_temp_to_code(structÂ
> > > chip_tsadc_table table,
> > > ÂÂÂÂÂÂ}
> > > ÂÂÂÂexit:
> > > -ÂÂÂÂpr_err("Invalid the conversion, error=%d\n", error);
> > > +ÂÂÂÂpr_err("%s: invalid temperature, temp=%d error=%d\n",
> > > +ÂÂÂÂÂÂÂÂ__func__, temp, error);
> > I have do some similar for rockchip inside thermal driver.ÂÂForget
> > toÂ
> > send for upstream. :(
> > exit:
> > ÂÂÂÂpr_err("%s: Invalid conversion table: code=%d,
> > temperature=%d\n",
> > ÂÂÂÂÂÂÂÂÂÂÂ__func__, error, temp);
> > 
> > > 
> > > ÂÂÂÂÂÂreturn error;
> > > Â }
> > > Â @@ -475,7 +476,9 @@ static int rk_tsadcv2_code_to_temp(structÂ
> > > chip_tsadc_table table, u32 code,
> > > ÂÂÂÂÂÂÂÂÂÂ}
> > > ÂÂÂÂÂÂÂÂÂÂbreak;
> > > ÂÂÂÂÂÂdefault:
> > > -ÂÂÂÂÂÂÂÂpr_err("Invalid the conversion table\n");
> > > +ÂÂÂÂÂÂÂÂpr_err("%s: invalid conversion table, mode=%d\n",
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂ__func__, table.mode);
> > > +ÂÂÂÂÂÂÂÂreturn -EINVAL;
> CHECK: Alignment should match open parenthesis
> #428: FILE: drivers/thermal/rockchip_thermal.c:428:
> +ÂÂÂÂpr_err("%s: invalid temperature, temp=%d error=%d\n",
> +ÂÂÂÂÂÂÂÂ__func__, temp, error);
> 
> CHECK: Alignment should match open parenthesis
> #480: FILE: drivers/thermal/rockchip_thermal.c:480:
> +ÂÂÂÂÂÂÂÂpr_err("%s: invalid conversion table, mode=%d\n",
> +ÂÂÂÂÂÂÂÂÂÂÂÂ__func__, table->mode);
> 
> 
> I'm ready to resend all rockchip thermal patches. (contain them)
> 
so I will ignore patch 2/3 and 3/3 for now and wait for your new patch
set.

thanks,
rui
> > 
> > > 
> > > ÂÂÂÂÂÂ}
> > > ÂÂÂÂÂÂÂÂ/*
> > 
> > 
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip