Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

[Caesar Wang]

å 2016å11æ22æ 10:15, Brian Norris åé:
> On Tue, Nov 22, 2016 at 09:51:23AM +0800, Caesar Wang wrote:
> > CHECK: Alignment should match open parenthesis
> > #428: FILE: drivers/thermal/rockchip_thermal.c:428:
> > +    pr_err("%s: invalid temperature, temp=%d error=%d\n",
> > +        __func__, temp, error);
> >
> > CHECK: Alignment should match open parenthesis
> > #480: FILE: drivers/thermal/rockchip_thermal.c:480:
> > +        pr_err("%s: invalid conversion table, mode=%d\n",
> > +            __func__, table->mode);
> What patch are you checking? I ran mine through checkpatch, and there
> are no problems.

That  just checkcode on Chromeos kernelv4.4,  that trivial things :)
$chromiumos/src/third_party/kernel/v4.4$ checkcode 
drivers/thermal/rockchip_thermal.c
CHECK: Alignment should match open parenthesis
#428: FILE: drivers/thermal/rockchip_thermal.c:428:
+    pr_err("%s: invalid temperature, temp=%d error=%d\n",
+        __func__, temp, error);
...

vi drivers/thermal/rockchip_thermal.c +428 or  vi 
drivers/thermal/rockchip_thermal.c +480,

> Did you perhaps mangle the tabs into spaces when you
> saved the patch?
>
> > I'm ready to resend all rockchip thermal patches. (contain them)
> I see no reason to resend so far; the only criticism was on the 1st
> patch (a non-critical patch to the core thermal code; the others are
> relatively independent, as long as you don't care that I'm adding
> another error return without fixing up the broken
> CONFIG_THERMAL_EMULATION support).
>
> Brian