Re: [PATCH] USB: serial: cp210x: Use tcflag_t to fix incompatible pointer type

From: Johan Hovold
Date: Mon Nov 21 2016 - 09:58:54 EST


On Mon, Nov 21, 2016 at 01:19:31PM +0100, Geert Uytterhoeven wrote:
> On sparc32, tcflag_t is unsigned long, unlike all other architectures:
>
> drivers/usb/serial/cp210x.c: In function 'cp210x_get_termios':
> drivers/usb/serial/cp210x.c:717:3: warning: passing argument 2 of 'cp210x_get_termios_port' from incompatible pointer type
> cp210x_get_termios_port(tty->driver_data,
> ^
> drivers/usb/serial/cp210x.c:35:13: note: expected 'unsigned int *' but argument is of type 'tcflag_t *'
> static void cp210x_get_termios_port(struct usb_serial_port *port,
> ^
>
> Consistently use tcflag_t to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Applied for -next as this an old warning for something that should be
benign on 32-bit.

Thanks,
Johan