Re: [PATCH 14/18] [media] RedRat3: Rename a jump label in redrat3_init_rc_dev()

From: Mauro Carvalho Chehab
Date: Fri Nov 18 2016 - 07:52:57 EST


Em Thu, 13 Oct 2016 18:42:16 +0200
SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> escreveu:

> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 13 Oct 2016 15:00:12 +0200
>
> Adjust a jump label according to the Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/media/rc/redrat3.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
> index 74d93dd..055f214 100644
> --- a/drivers/media/rc/redrat3.c
> +++ b/drivers/media/rc/redrat3.c
> @@ -890,12 +890,11 @@ static struct rc_dev *redrat3_init_rc_dev(struct redrat3_dev *rr3)
> ret = rc_register_device(rc);
> if (ret < 0) {
> dev_err(rr3->dev, "remote dev registration failed\n");
> - goto out;
> + goto free_device;
> }
>
> return rc;
> -
> -out:
> +free_device:
> rc_free_device(rc);
> return NULL;
> }

I don't see *any* sense on patches like this. Please don't flood me with
useless patches like that.

I'll silently ignore any patches like this during my review.

Regards,
Mauro



Thanks,
Mauro