RE: [PATCH v2 2/2] MIPS: DTS: img: add device tree for Marduk board

From: James Hartley
Date: Fri Nov 18 2016 - 06:27:46 EST


Hi Rahul,

> -----Original Message-----
> From: Rob Herring [mailto:robh@xxxxxxxxxx]
> Sent: 18 October 2016 15:14
> To: Rahul Bedarkar
> Cc: Ralf Baechle; Mark Rutland; James Hartley; linux-mips@xxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/2] MIPS: DTS: img: add device tree for Marduk
> board
>
> On Fri, Oct 14, 2016 at 11:25:55AM +0530, Rahul Bedarkar wrote:
> > Add support for Imagination Technologies' Marduk board which is based
> > on Pistachio SoC. It is also known as Creator Ci40. Marduk is legacy
> > name and will be there for decades.
> >
> > Documentation for this board can be found on
> > https://docs.creatordev.io/ci40/
> >
> > This patch adds initial support for board with following peripherals:
> >
> > * PWM based heartbeat LED
> > * GPIO based buttons
> > * SPI NOR flash on SPI1
> > * UART0 and UART1
> > * SD card
> > * Ethernet
> > * USB
> > * PWM
> > * ADC
> > * I2C
> >
> > Signed-off-by: Rahul Bedarkar <rahul.bedarkar@xxxxxxxxxx>
> > ---
> > Changes in v2:
> > - Correct RAM size. It is 256MB instead of 128MB.
> > - Rename nodes pwm_leds -> leds and gpio_keys -> keys (Suggested by
> Rob Herring)
> > - Don't use '_' in node name for internal_dac_supply (Suggested by Rob
> Herring)
> > - Add part name in compatible string for spi-nor (Suggested by Rob
> > Herring)
> > ---
> > .../bindings/mips/img/pistachio-marduk.txt | 10 ++
> > MAINTAINERS | 6 +
> > arch/mips/boot/dts/img/Makefile | 9 ++
> > arch/mips/boot/dts/img/pistachio_marduk.dts | 163
> +++++++++++++++++++++
> > 4 files changed, 188 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt
> > create mode 100644 arch/mips/boot/dts/img/Makefile create mode
> > 100644 arch/mips/boot/dts/img/pistachio_marduk.dts
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>

Acked-by: James Hartley <james.hartley@xxxxxxxxxx>