Re: [PATCH 3/3] trace-cmd record: add --cpu-list option

From: Luiz Capitulino
Date: Wed Nov 16 2016 - 09:10:02 EST


On Tue, 15 Nov 2016 16:38:19 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Fri, 28 Oct 2016 17:14:56 -0400
> Luiz Capitulino <lcapitulino@xxxxxxxxxx> wrote:
>
>
> > >
> > > cpu_set(ret_mask, i) sets bits from begin to end in uint64_t cpumask
> > > from below.
> > >
> > > What happens if this range is greater than 64? We already have boxes
> > > that run this with 80 CPUs. Looks to be out of memory range to me.
> >
> > The best solution is probably to detect the number of CPUs at run-time
> > and use the CPU_SET() API. The lazy and ugly solution is to just fail.
> >
> > Any objections to the CPU_SET() solution?
> >
>
> I thought I replied to this, but I'm guessing the reply is still
> pending.
>
> I have no objecting. I'd like to see a patch though.

I imagined you didn't have objections :) I haven't started working
on this yet because I'm very busy at other stuff. But I'll go
back to this soon.