Re: [PATCH] watchdog: jz4740: Fix modular build

[Guenter Roeck]

On 11/10/2016 04:02 PM, Stephen Boyd wrote:
> Compiling this driver as a module causes a build error because a
> semicolon is missing after MODULE_DEVICE_TABLE. Add it.
>
>   CC [M]  drivers/watchdog/jz4740_wdt.o
> drivers/watchdog/jz4740_wdt.c:154:1: error: expected â,â or â;â before âstaticâ
> drivers/watchdog/jz4740_wdt.c:218:11: error: âjz4740_wdt_probeâ undeclared here (not in a function)
>
> Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@xxxxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

Oops :-(

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/jz4740_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
> index c8d51ddb26d5..20627f22baf6 100644
> --- a/drivers/watchdog/jz4740_wdt.c
> +++ b/drivers/watchdog/jz4740_wdt.c
> @@ -148,7 +148,7 @@ static const struct of_device_id jz4740_wdt_of_matches[] = {
>  	{ .compatible = "ingenic,jz4740-watchdog", },
>  	{ /* sentinel */ }
>  };
> -MODULE_DEVICE_TABLE(of, jz4740_wdt_of_matches)
> +MODULE_DEVICE_TABLE(of, jz4740_wdt_of_matches);
>  #endif
>
>  static int jz4740_wdt_probe(struct platform_device *pdev)