Re: [PATCH] perf/x86: add more Intel uncore IMC PCI ID for SkyLake

[Thomas Gleixner]

On Mon, 7 Nov 2016, kan.liang@xxxxxxxxx wrote:
> There are several PCI IDs are missed for Intel SkyLake IMC.

There are ... are ???

> This patch adds the PCI IDs for SkyLake Y, U, H and S platforms.

"This patch" is just a bad habit. We already know that this is a patch. See
Documentation/SubmittingPatches, which has an explanation for this.

> This patch also rename 0x191f and 0x190c according to the document.

You do not rename the hex constants. You rename the ID macros ...

> These PCI IDs are defined in the document as below.
> 
> Y & U platforms
> http://www.intel.com/content/www/us/en/processors/core/
> 6th-gen-core-family-mobile-u-y-processor-lines-datasheet-vol-2.html
> 
> S platform
> http://www.intel.com/content/www/us/en/processors/core/
> desktop-6th-gen-core-family-datasheet-vol-2.html
> 
> H platform
> http://www.intel.com/content/www/us/en/processors/core/
> 6th-gen-core-family-mobile-h-processor-lines-datasheet-vol-2.html

As I said before several times. These links are just horrible. The Intel
webpage is restructured every so often, so the links might be stale before
thishits Linus tree. We really need persistant links, not just the link of
today.

One way to achive that is to open a bugzilla entry in the kernel org
bugzilla and stick the files there for permanent reference, unless Intel
comes up with something which is not affected by their constant web page
reshuffling.

Thanks,

	tglx