Re: [PATCH v3 0/1] mm/mempolicy.c: forbid static or relative flags for local NUMA mode

From: David Rientjes
Date: Mon Oct 31 2016 - 20:23:04 EST


On Thu, 27 Oct 2016, Piotr Kwapulinski wrote:

> The MPOL_F_STATIC_NODES and MPOL_F_RELATIVE_NODES flags are irrelevant
> when setting them for MPOL_LOCAL NUMA memory policy via set_mempolicy
> or mbind.
> Return the "invalid argument" from set_mempolicy and mbind whenever
> any of these flags is passed along with MPOL_LOCAL.
> It is consistent with MPOL_PREFERRED passed with empty nodemask.
> It slightly shortens the execution time in paths where these flags
> are used e.g. when trying to rebind the NUMA nodes for changes in
> cgroups cpuset mems (mpol_rebind_preferred()) or when just printing
> the mempolicy structure (/proc/PID/numa_maps).
> Isolated tests done.
>
> Signed-off-by: Piotr Kwapulinski <kwapulinski.piotr@xxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>