Re: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes

From: Kevin Hilman
Date: Mon Oct 31 2016 - 16:46:29 EST


Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> writes:

> Hi Bartosz,
>
> Thank you for the patch.
>
> On Monday 31 Oct 2016 15:45:37 Bartosz Golaszewski wrote:
>> Enable the MSTPRI configuration and DDR2/mDDR memory controller
>> nodes on da850-lcdk. This is needed in order to adjust the memory
>> throughput constraints for better tilcdc support.
>
> Is there a reason not to enable these unconditionally in da850.dtsi (or rather
> not disabling them) instead of handling it per board ?

Right. They should be enabled by default in DT. The drivers already
have board-specific compatible checks.

Kevin