Re: [PATCH 1/1] nvdimm: use the right length of "pmem"

From: Dan Williams
Date: Sun Oct 30 2016 - 11:50:30 EST


On Sat, Oct 29, 2016 at 4:28 AM, Nicolas Iooss
<nicolas.iooss_linux@xxxxxxx> wrote:
> In order to test that the name of a resource begins with "pmem", call
> strncmp() with 4 as length instead of 3 to match the whole prefix.
>
> Fixes: 16660eaea0cc ("libnvdimm, namespace: update label implementation
> for multi-pmem")
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>

Thanks, although I would not call this out as a fix since the length
parameter could be 1 and still do the right thing. I.e. we're
distinguishing "blk" from "pmem" resources. I'll add this for 4.10 as
a cleanup.