Re: [PATCH] EDAC: expose per-dimm error counts in sysfs

[Mauro Carvalho Chehab]

Em Thu, 27 Oct 2016 20:07:16 +0200
Borislav Petkov <bp@xxxxxxxxx> escreveu:

> On Tue, Oct 25, 2016 at 04:25:51PM -0700, Aaron Miller wrote:
> 
> <--- This patch needs a commit message.
> 
> Especially as to *why* we need this.

Also, if you're changing the sysfs ABI, you need to update the EDAC
documentation accordingly.

> 
> > Signed-off-by: Aaron Miller <aaronmiller@xxxxxx>
> > ---
> >  drivers/edac/edac_mc_sysfs.c | 38 ++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 38 insertions(+)  
> 
> Regardless, something's still not right yet:
> 
> $ echo 1 > /sys/kernel/debug/edac/mc0/fake_inject_channel
> $ echo 2 > /sys/kernel/debug/edac/mc0/fake_inject_slot
> $ echo 3 > /sys/kernel/debug/edac/mc0/fake_inject_count
>        ^
> 
> $ echo 1 > /sys/kernel/debug/edac/mc0/fake_inject
> 
> $ grep . /sys/devices/system/edac/mc/mc0/*count
> /sys/devices/system/edac/mc/mc0/ce_count:3
> 					 ^
> 
> /sys/devices/system/edac/mc/mc0/ce_noinfo_count:0
> /sys/devices/system/edac/mc/mc0/ue_count:0
> /sys/devices/system/edac/mc/mc0/ue_noinfo_count:0
> 
> $ grep -r . /sys/devices/system/edac/mc/mc0/dimm*/* 2>/dev/null | grep ce_count
> /sys/devices/system/edac/mc/mc0/dimm0/dimm_ce_count:0
> /sys/devices/system/edac/mc/mc0/dimm3/dimm_ce_count:0
> /sys/devices/system/edac/mc/mc0/dimm6/dimm_ce_count:0
> /sys/devices/system/edac/mc/mc0/dimm9/dimm_ce_count:0
> 						    ^
> 
> There should be 3 somewhere in the DIMM counters...
> 



Thanks,
Mauro