Re: [PATCH 4/5] ARM: davinci: enable LEDs default-on trigger in default config

[David Lechner]

On 10/27/2016 06:29 AM, Sekhar Nori wrote:
> On Saturday 22 October 2016 12:06 AM, David Lechner wrote:
> > The LEDs default-on trigger is nice to have. For example, it can be used
> > to configure a LED as a power indicator.
> >
> > Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
> > ---
> >  arch/arm/configs/davinci_all_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig
> > index 9d7f0bc..e380743 100644
> > --- a/arch/arm/configs/davinci_all_defconfig
> > +++ b/arch/arm/configs/davinci_all_defconfig
> > @@ -181,6 +181,7 @@ CONFIG_LEDS_GPIO=m
> >  CONFIG_LEDS_TRIGGERS=y
> >  CONFIG_LEDS_TRIGGER_TIMER=m
> >  CONFIG_LEDS_TRIGGER_HEARTBEAT=m
> > +CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
>
> Can this be module like rest of the triggers? It will come on later, but
> not sure if you care about the difference that much. Having it a module
> will be better for those boards that don't need it.
>
> Thanks,
> Sekhar

Yes, module is OK here.