RE: [PATCH 2/2] regmap: Avoid namespace collision within macro

From: Ramesh Shanmugasundaram
Date: Thu Oct 27 2016 - 10:08:57 EST


> On Thu, Oct 27, 2016 at 10:33:19AM +0100, Ramesh Shanmugasundaram wrote:
>
> > #define regmap_read_poll_timeout(map, addr, val, cond, sleep_us,
> > timeout_us) \ ({ \
> > - ktime_t timeout = ktime_add_us(ktime_get(), timeout_us); \
> > + ktime_t __timeout = ktime_add_us(ktime_get(), timeout_us); \
> > int ret; \
>
> Why is timeout an issue and not ret?

It is! However, it is less likely for someone to use "ret" as a variable name for the given parameter list. Hence, I fixed timeout alone. Feel free to fix "ret" as well.

Thanks,
Ramesh