Re: [PATCH 2/2] mfd: hi655x-pmic: Fix module autoload when registered via OF

From: Lee Jones
Date: Wed Oct 26 2016 - 08:45:17 EST


On Fri, 14 Oct 2016, Javier Martinez Canillas wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mfd/hi655x-pmic.ko | grep alias
>
> After this patch:
>
> $ modinfo drivers/mfd/hi655x-pmic.ko | grep alias
> alias: of:N*T*Chisilicon,hi655x-pmicC*
> alias: of:N*T*Chisilicon,hi655x-pmic
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> ---
>
> drivers/mfd/hi655x-pmic.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> index 0fc62995695b..ba706adee38b 100644
> --- a/drivers/mfd/hi655x-pmic.c
> +++ b/drivers/mfd/hi655x-pmic.c
> @@ -169,6 +169,7 @@ static const struct of_device_id hi655x_pmic_match[] = {
> { .compatible = "hisilicon,hi655x-pmic", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, hi655x_pmic_match);
>
> static struct platform_driver hi655x_pmic_driver = {
> .driver = {

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog