Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration.

[David Lechner]

Hi Sekhar,

On 10/25/2016 05:17 AM, Sekhar Nori wrote:
> On Tuesday 25 October 2016 03:07 PM, Axel Haslam wrote:
> > Hi Sekar,
> >
> > On Tue, Oct 25, 2016 at 10:10 AM, Sekhar Nori <nsekhar@xxxxxx> wrote:
> > > On Monday 24 October 2016 10:16 PM, ahaslam@xxxxxxxxxxxx wrote:
> > > > From: David Lechner <david@xxxxxxxxxxxxxx>
> > > >
> > > > The CFGCHIP registers are used by a number of devices, so using a syscon
> > > > device to share them. The first consumer of this will by the phy-da8xx-usb
> > > > driver.
> > > >
> > > > Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
> > > > [Axel: minor fix: change id to -1]
> > >
> > > Can you please clarify this change? There could be other syscon devices
> > > on the chip for other common registers. Why use the singular device-id?
> >
> > in the case of non DT boot, the phy driver is looking for "syscon" :
> >
> > d_phy->regmap = syscon_regmap_lookup_by_pdevname("syscon");
> >
> > if we register the syscon driver with id = 0, the actual name of the syscon
> > device will be "syscon.0" and the phy driver will fail to probe, because
> > the strncmp match in the syscon driver (syscon_match_pdevname)
> > will fail.
> >
> > should i change the phy driver instead?
>
> Yes, please. Forcing only one syscon region for the whole chip will be
> too restrictive, I am pretty sure.
>
> Thanks,
> Sekhar

In the previous review, you requested that this be changed to -1 [1].

If we change it back to 0, it will also require reverting a patch to the 
phy driver that has already been merged[2].

[1]: http://www.gossamer-threads.com/lists/linux/kernel/2435807?page=last
[2]: http://www.gossamer-threads.com/lists/linux/kernel/2518804