Re: [PATCH] gpio: mxc: Shift generic request/free after gpiochip registration

From: Linus Walleij
Date: Tue Oct 25 2016 - 08:11:17 EST


On Tue, Oct 25, 2016 at 6:57 AM, Deepak Das <deepak_das@xxxxxxxxxx> wrote:

> generic gpio request/free should be added after gpiocip registration
> to validate mapping of gpiochip with pinctrl subsystem.
>
> gpiochip->pin_ranges list contains the information used by pinctrl
> subsystem to configure corresponding pins for gpio usage.
> This list will be empty if gpiochip fails to map with
> pinctrl subsystem for any reason.
> For Ex.:-
> generic gpio request/free should not be used if IOMUX pin controller
> device node is disabled in device tree.
>
> This commit checks above list and skips adding generic gpio request/free
> if list is found empty.
>
> Signed-off-by: Deepak Das <deepak_das@xxxxxxxxxx>
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx>

Third time I find this in my inbox and it still doesn't apply.

Yours,
Linus Walleij