Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers

[Paolo Bonzini]

On 25/10/2016 13:43, Radim KrÄmÃÅ wrote:
> Oops, silly mistake -- apic_timer_expired() was in the 'else' branch in
> [5/5] and I didn't invert the condition after moving it.
> 
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index 6244988418be..d7e74c8ec8ca 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -1354,8 +1354,8 @@ static void start_sw_period(struct kvm_lapic *apic)
>  		return;
>  
>  	if (apic_lvtt_oneshot(apic) &&
> -	    ktime_after(apic->lapic_timer.target_expiration,
> -	                apic->lapic_timer.timer.base->get_time())) {
> +	    !ktime_after(apic->lapic_timer.target_expiration,
> +	                 apic->lapic_timer.timer.base->get_time())) {
>  		apic_timer_expired(apic);
>  		return;
>  	}
> 
> Paolo, can you squash that?

Yes, will do.

Paolo