Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

From: Mark Brown
Date: Mon Oct 24 2016 - 14:20:04 EST


On Mon, Oct 24, 2016 at 08:11:40PM +0200, Axel Haslam wrote:
> On Mon, Oct 24, 2016 at 7:53 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:

> > does it make sense to report this as a mode, we don't report other error
> > conditions as modes but instead use REGULATOR_STATUS_ with the
> > get_status() operation?

> I used mode, because when the regulator toggles the overcurrent
> line, it means that it has entered a current limited mode, at least the
> regulator im looking at. ill change to STATUS

That's not what regulator modes are - please look at the documentation
for the defines here. They're about the quality of regulation.

Attachment: signature.asc
Description: PGP signature