Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity

[Jiri Olsa]

On Mon, Oct 24, 2016 at 11:02:43AM +0900, Namhyung Kim wrote:
> Applying cpu color always doesn't help readability IMHO.  Instead it
> might be better to applying the color when there's an activity on those
> CPUs.

ok, I added it to easily spot cpu columns I was interested in,
but I think I can live with dotted line ;-)

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka

> 
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> ---
>  tools/perf/builtin-sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index f5503ca22e1c..78006e991d91 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -1479,7 +1479,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
>  			cpu_color = COLOR_CPUS;
>  
>  		if (cpu != this_cpu)
> -			color_fprintf(stdout, cpu_color, " ");
> +			color_fprintf(stdout, color, " ");
>  		else
>  			color_fprintf(stdout, cpu_color, "*");
>  
> -- 
> 2.10.0
>