Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros

From: Luc, Piotr
Date: Mon Oct 24 2016 - 09:15:36 EST


On Fri, 2016-10-14 at 13:56 +0200, Thomas Gleixner wrote:
> On Thu, 13 Oct 2016, Piotr Luc wrote:

> >
> > + case INTEL_FAM6_SANDYBRIDGE: /* SNB */
>
> Especialy those, which are completely useless?
>
> The defines are there to be self explaining and the extra verbose
> information should be in the header file defining the macros and not
> in the
> source code.

Hi

I submitted the turbostat patchsetÂ
https://lkml.kernel.org/r/20161018210652.29365-1-piotr.luc@xxxxxxxxxÂto
address the issues.

Regards
Piotr